Re: GUI unresponsive while renaming files on S3
Indeed. Thanks for your feedback. I'll try to improve this.
- martin
Post a reply
Before posting, please read how to report bug or request support effectively.
Bug reports without an attached log file are usually useless.
Topic review
- refack
GUI unresponsive while renaming files on S3
V: 5.13.8172
Server S3 (us-east-1)
I'm assuming GUI rename assumes the action will be quick, but since on S3 rename is actually a full object PUT & DELETE cycle that can take several seconds.
https://github.com/winscp/winscp/blob/5.13.1/source/core/S3FileSystem.cpp#L964
I guess this need to be split into an async operation with a callback, or something with a progress indicator (maybe even moved to the GUI queue)
P.S. Great piece of software, that's why I was happy to donate.
Server S3 (us-east-1)
I'm assuming GUI rename assumes the action will be quick, but since on S3 rename is actually a full object PUT & DELETE cycle that can take several seconds.
https://github.com/winscp/winscp/blob/5.13.1/source/core/S3FileSystem.cpp#L964
I guess this need to be split into an async operation with a callback, or something with a progress indicator (maybe even moved to the GUI queue)
. 2018-03-28 15:18:56.366 PUT /ddl/YYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY HTTP/1.1
. 2018-03-28 15:18:56.366 User-Agent: WinSCP/5.13 neon/0.30.2
. 2018-03-28 15:18:56.366 Keep-Alive:
. 2018-03-28 15:18:56.366 Connection: TE, Keep-Alive
. 2018-03-28 15:18:56.366 TE: trailers
. 2018-03-28 15:18:56.366 x-amz-date: 20180328T191856Z
. 2018-03-28 15:18:56.366 x-amz-copy-source: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
.
.
.
. 2018-03-28 15:19:09.099 DELETE XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX HTTP/1.1
P.S. Great piece of software, that's why I was happy to donate.