Post a reply

Options
Add an Attachment

If you do not want to add an Attachment to your Post, please leave the Fields blank.

(maximum 10 MB; please compress large files; only common media, archive, text and programming file formats are allowed)

Options

Topic review

martin

Ok. Done. Thanks.
sessile.fielder

Nope, I don't think it's important at all since you're already disposing the stream it's using, but it is good practice. I was just going through the source to try to understand some things better and noticed it.
martin

Re: Dispose XMLReader in SessionLogReader

Thanks for your hint.
Is there any reason you consider it that important? Apart from being a good practice?
sessile.fielder

Dispose XMLReader in SessionLogReader

I think you need to add this to your Cleanup method:

((IDisposable)_reader).Dispose();

You have to cast it to IDisposable before disposing it because it uses explicit interface implementation.