Post a reply

Before posting, please read how to report bug or request support effectively.

Bug reports without an attached log file are usually useless.

Options
Add an Attachment

If you do not want to add an Attachment to your Post, please leave the Fields blank.

(maximum 10 MB; please compress large files; only common media, archive, text and programming file formats are allowed)

Options

Topic review

martin

Re: Minor Inno Setup Bug related to Chrome bundling

Thanks for your report.
I did not have a luck applying your patch though. I've tried to fix it myself. Can you share your final copy of the .iss file to comparison?
baryon

Minor Inno Setup Bug related to Chrome bundling

The Inno Setup script for 5.5.1 is missing a couple ifdefs for Chrome, and has one in the wrong spot. Here's a patch.

$ diff ../winscp551source/deployment/winscpsetup.iss fixed.iss

748d751
< #ifdef Chrome
756a760,761
> #ifdef Chrome
>
1342a1348
> #ifdef Chrome
1344a1351
> #endif
1473a1481
> #ifdef Chrome
1477a1486
> #endif
1503a1513
> #ifdef Chrome
1517a1528
> #endif


Edit: This problem still exists in the CVS version of the ISS script.