Data corruption problems with direct open and then save of documents

Hello there,

I have long been a fan of SCP and have used it personally for quite a while on my Linux systems. I recently installed a test installation of WinSSHd on an XP server with XP clients using WinSCP 3.56 with the Explorer interface and have come across two issues that can cause data loss and/or corruption. I have also tested these issues on a Mandrake 9.0 Linux server and they respond the same way (which is to be expected).
- When the user double clicks (or selects open) a Word document, the document is transferred and opened in Word, after the user exits Word (and saves the document) it is then uploaded back to the server and is corrupted. I tested this with notepad and .TXT files and found that the CR/LF is being replaced with LF even though the default transfer mode is binary. Attached is the log file that shows this is also the case for the word Document
- When using the Explorer interface and the user performs a drag and drop to the Desktop or the "My Documents" folder, WinSCP attempts to perform a move rather then a copy. If the user blindly goes on with the process the file is moved from the server and could be lost forever. In my experience this type of process is typical of the user, particularly when they are familiar with using file servers in the office to obtain local copies of documents. I would like to completely disable the move feature so that a copy is the only option that could be performed for a session.

For my uses WinSCP has been an excellent tool. Unfortunately if I unleash this on my office mates and other uses as an alternate to VPN access I am assured that their natural Windows tendencies and usage patterns will cause loss of data.

Allen

**** Log from Open of "Test.txt"

File: "/home/allen/xfer/Test.txt"
Copying "/home/allen/xfer/Test.txt" to local directory started.
Binary transfer mode selected.
Opening remote file.
Type: SSH_FXP_OPEN, Size: 42, Number: 54787
Type: SSH_FXP_HANDLE, Size: 13, Number: 54787
Type: SSH_FXP_READ, Size: 25, Number: 55045
Status/error code: 1
3 skipped SSH_FXP_WRITE, SSH_FXP_READ, SSH_FXP_DATA and SSH_FXP_STATUS packets.
Type: SSH_FXP_CLOSE, Size: 13, Number: 55556
Type: SSH_FXP_STATUS, Size: 24, Number: 55556
Status/error code: 0
Copying 1 files/directories to remote directory "/home/allen/xfer"
PrTime: Yes; PrRO: Yes; Rght: rw-r--r--; PrR: No; FnCs: N; RIC: Yes; Resume: N (102400); CalcS: Yes; Mask: *.*
TM: A; AscM: *.*htm*; *.txt; *.php*; *.cgi; *.c; *.cpp; *.h; *.pas; *.bas; *.tex; *.pl; .htaccess; *.xtml; *.css; *.cfg; *.ini; *.sh; *.xml
File: "C:\DOCUME~1\ASuski\LOCALS~1\Temp\scp01032\Test.txt"
Copying "C:\DOCUME~1\ASuski\LOCALS~1\Temp\scp01032\Test.txt" to remote directory started.
Ascii transfer mode selected.
Opening remote file.
Type: SSH_FXP_OPEN, Size: 42, Number: 55811
Type: SSH_FXP_HANDLE, Size: 13, Number: 55811
Type: SSH_FXP_WRITE, Size: 109, Number: 56070
1 skipped SSH_FXP_WRITE, SSH_FXP_READ, SSH_FXP_DATA and SSH_FXP_STATUS packets.
Type: SSH_FXP_CLOSE, Size: 13, Number: 56324
Type: SSH_FXP_STATUS, Size: 24, Number: 56324
Status/error code: 0
Type: SSH_FXP_SETSTAT, Size: 46, Number: 56585
Type: SSH_FXP_STATUS, Size: 24, Number: 56585
Status/error code: 0
Listing directory "/home/allen/xfer".
Type: SSH_FXP_OPENDIR, Size: 25, Number: 56843
Type: SSH_FXP_HANDLE, Size: 13, Number: 56843
Type: SSH_FXP_READDIR, Size: 13, Number: 57100
Type: SSH_FXP_NAME, Size: 431, Number: 57100
Type: SSH_FXP_READDIR, Size: 13, Number: 57356
Type: SSH_FXP_STATUS, Size: 28, Number: 57356
Status/error code: 1
Type: SSH_FXP_CLOSE, Size: 13, Number: 57604
Type: SSH_FXP_STATUS, Size: 24, Number: 57604
Status/error code: 0

**** Log from open of a TEST.DOC
File: "/home/allen/xfer/Test.doc"
Copying "/home/allen/xfer/Test.doc" to local directory started.
Binary transfer mode selected.
Opening remote file.
Type: SSH_FXP_OPEN, Size: 42, Number: 64003
Type: SSH_FXP_HANDLE, Size: 13, Number: 64003
Type: SSH_FXP_READ, Size: 25, Number: 64261
Status/error code: 1
19 skipped SSH_FXP_WRITE, SSH_FXP_READ, SSH_FXP_DATA and SSH_FXP_STATUS packets.
Type: SSH_FXP_CLOSE, Size: 13, Number: 66820
Type: SSH_FXP_STATUS, Size: 24, Number: 66820
Status/error code: 0
Copying 1 files/directories to remote directory "/home/allen/xfer"
PrTime: Yes; PrRO: Yes; Rght: rw-r--r--; PrR: No; FnCs: N; RIC: Yes; Resume: N (102400); CalcS: Yes; Mask: *.*
TM: A; AscM: *.*htm*; *.txt; *.php*; *.cgi; *.c; *.cpp; *.h; *.pas; *.bas; *.tex; *.pl; .htaccess; *.xtml; *.css; *.cfg; *.ini; *.sh; *.xml
File: "C:\DOCUME~1\ASuski\LOCALS~1\Temp\scp03403\Test.doc"
Copying "C:\DOCUME~1\ASuski\LOCALS~1\Temp\scp03403\Test.doc" to remote directory started.
Ascii transfer mode selected.
Opening remote file.
Type: SSH_FXP_OPEN, Size: 42, Number: 67075
Type: SSH_FXP_HANDLE, Size: 13, Number: 67075
Type: SSH_FXP_WRITE, Size: 4121, Number: 67334
9 skipped SSH_FXP_WRITE, SSH_FXP_READ, SSH_FXP_DATA and SSH_FXP_STATUS packets.
Type: SSH_FXP_CLOSE, Size: 13, Number: 68612
Type: SSH_FXP_STATUS, Size: 24, Number: 68612
Status/error code: 0
Type: SSH_FXP_SETSTAT, Size: 46, Number: 68873
Type: SSH_FXP_STATUS, Size: 24, Number: 68873
Status/error code: 0
Listing directory "/home/allen/xfer".
Type: SSH_FXP_OPENDIR, Size: 25, Number: 69131
Type: SSH_FXP_HANDLE, Size: 13, Number: 69131
Type: SSH_FXP_READDIR, Size: 13, Number: 69388
Type: SSH_FXP_NAME, Size: 431, Number: 69388
Type: SSH_FXP_READDIR, Size: 13, Number: 69644
Type: SSH_FXP_STATUS, Size: 28, Number: 69644
Status/error code: 1
Type: SSH_FXP_CLOSE, Size: 13, Number: 69892
Type: SSH_FXP_STATUS, Size: 24, Number: 69892
Status/error code: 0

asuski wrote:

- When the user double clicks (or selects open) a Word document, the document is transferred and opened in Word, after the user exits Word (and saves the document) it is then uploaded back to the server and is corrupted. I tested this with notepad and .TXT files and found that the CR/LF is being replaced with LF even though the default transfer mode is binary. Attached is the log file that shows this is also the case for the word Document

Thanks! I do not understand why noone has noted this bug so far :-(

- When using the Explorer interface and the user performs a drag and drop to the Desktop or the "My Documents" folder, WinSCP attempts to perform a move rather then a copy.

What version? Do you have shell extension installed and enabled (see Preferences dialog)?

Completely uninstalled WinSCP and re-installed and the corruption problem seems to have gone away. I had been installing new versions over older versions. This problem occured on more then one computer so it must be related to the install over an older version

- When using the Explorer interface and the user performs a drag and drop to the Desktop or the "My Documents" folder, WinSCP attempts to perform a move rather then a copy.

What version? Do you have shell extension installed and enabled (see Preferences dialog)?[/quote]
Yes, I did have the extensions installed and enabled. As a matter of fact when I try to drag a folder to the desktop I see a folder being created and then receive the following error "WinSCP was not able to detect folder, where the dragged files(s) was dropped ....". Again this is on more then one machine and the uninstall and reinstall did not solve the problem. I did perform a fresh install on a virgin machine and the file extension work great from there.

Allen

asuski wrote:

Completely uninstalled WinSCP and re-installed and the corruption problem seems to have gone away. I had been installing new versions over older versions. This problem occured on more then one computer so it must be related to the install over an older version

I do not think that reinstallation can help. When edited/opened (double-clicked) file is uploaded back to the server (after being modified), it is ALWAYS transfered in text mode. This cause corruption with binary files (like Word .doc documents). The bug is in all WinSCP versions (that support editing/opening).

Yes, I did have the extensions installed and enabled. As a matter of fact when I try to drag a folder to the desktop I see a folder being created and then receive the following error "WinSCP was not able to detect folder, where the dragged files(s) was dropped ....". Again this is on more then one machine and the uninstall and reinstall did not solve the problem.

Does it help when you restart the computer after installing WinSCP?

martin wrote:

asuski wrote:

Completely uninstalled WinSCP and re-installed and the corruption problem seems to have gone away. I had been installing new versions over older versions. This problem occured on more then one computer so it must be related to the install over an older version

I do not think that reinstallation can help. When edited/opened (double-clicked) file is uploaded back to the server (after being modified), it is ALWAYS transfered in text mode. This cause corruption with binary files (like Word .doc documents). The bug is in all WinSCP versions (that support editing/opening).

Yes you are correct, my bad! I changed technique of testing with a smaller less complicated Word file (because of the time it took to upload/download) and as such it was not complicated enough to be affected by the ascii transfer. The problem definately still exists! Any idea when this issue will be addressed?

martin wrote:

asuski wrote:

Yes, I did have the extensions installed and enabled. As a matter of fact when I try to drag a folder to the desktop I see a folder being created and then receive the following error "WinSCP was not able to detect folder, where the dragged files(s) was dropped ....". Again this is on more then one machine and the uninstall and reinstall did not solve the problem.

Does it help when you restart the computer after installing WinSCP?

Yes! Reboot solved that problem. I was on travel and testing on a server that I did not want rebooted during the day. Reboot took care of the drag and drop problem on both machines.

By the way ... This forum is a nice tool and I really appreciate your regular attention to it :lol:

asuski wrote:

Yes you are correct, my bad! I changed technique of testing with a smaller less complicated Word file (because of the time it took to upload/download) and as such it was not complicated enough to be affected by the ascii transfer. The problem definately still exists! Any idea when this issue will be addressed?

In next version, but it won't be probably soon than in several weeks. I'm doing big changes.