I feel this is unintuitive, as in standard practice, programs should ask users whether to save or discard changes, not confirm that they want to proceed discarding changes. In the above case, there are two options:Confirm
This will cancel site editing. Do you want to continue?
[OK] [Cancel] [Help]
OK - A positive option which results in a negative action (canceling site editing and discarding changes)
Cancel - A negative option which does not result in any useful action (User is still required to click Save before choosing another site on the left, thus placing more work on the hands of the user).
The following alternative question would be more intuitive and more in-line with how other programs behave:
Note: [Help] button should really be just the [?] button on top right of the question box frame to avoid clutter.Site editing
You have edited the current site. Do you want to save your changes?
[Yes] [No] [Cancel]
This is intuitive because the selected user option results in a behavior consistent with the option wording:
Yes - A positive option that results in a positive action (saving the changes), then continues with changing to another site.
No - A negative option that results in a negative action (discarding the changes), then continues with changing to another site.
Cancel - A negative action that (in this case) results in a negative but safe action (stays in the site editing mode, does not save or discard changes, does not change to another site).
Related bug: If I edit a site but click the [X] button on top right, the changes are discarded and the Login dialog window is closed without any warning. I expected the above question to be asked in this case as well.