Bug 169 seems to be back (Upload back files modified by local custom command)

I reported this issue a while ago (https://winscp.net/forum/viewtopic.php?t=13955) and you quite rightly pointed out that it was already being tracked in bug #169. The issue was subsequently fixed (thanks!) but it seems to have come back recently.

As with my last report, I noticed the issue because changes I make to files on the remote side of a WinMerge comparison no longer get uploaded.

I'm running WinSCP 5.9.3 (Build 7136).

Thanks for your report.

Though, it works for me.

I have sent you an email with a debug version of WinSCP to the address you have used to register on this forum.

martin wrote:

Thanks for your report. Though, it works for me.
I have sent you an email with a debug version of WinSCP to the address you have used to register on this forum.

The problem seems to occur when I'm comparing a directory, but not when I'm comparing an individual file. In other words, if I compare an individual file, and copy differences from local to remote, the changes end up on the remote end (after WinSCP shows an overwrite confirmation dialog). If I compare the folder that contains the changed file, and copy the differences from local to remote, the changes do NOT end up on the remote end (there's also no WinSCP overwrite confirmation dialog).

I'm working with the debug version to create a simple test case that demonstrates the problem.

OK, the improvement was actually never implemented for files in subdirectories.

martin wrote:

OK, the improvement was actually never implemented for files in subdirectories.

Really? I could have sworn it was working until recently...

Any chance that you'll add subdirectory support? It would be so amazingly handy.

Sure, will see what a demand for this is.

It looks like directories were being handled in an earlier version, but that functionality was rolled back because it caused problems like this one: https://winscp.net/forum/viewtopic.php?t=15051

If I'm reading this correctly, then is there any chance that we could have some kind of a warning or flag that indicates whether changes to the local copy of remote files will be uploaded? Because currently it just fails silently and I only notice when I remember that there should always be an overwrite prompt and there isn't one.

But adding the directory handling again would be nice.

OK, you are right. I've forgot. Will look into it. If I have anything to test, I'll contact you.

This issue has been added to the tracker:
https://winscp.net/tracker/1526

I'm sending you an email with a development version of WinSCP to the address you have used to register on this forum.

I just noticed it happening again in the last couple of days. I'm running WinSCP 5.14.4 RC (Build 9136). When I compare individual files with the external tool (Winmerge), changes made to the remote side are uploaded fine. When I compare a directory, changes made to the remote side are not uploaded. I believe this was previously working.

jrivett wrote:

I just noticed it happening again in the last couple of days. I'm running WinSCP 5.14.4 RC (Build 9136). When I compare individual files with the external tool (Winmerge), changes made to the remote side are uploaded fine. When I compare a directory, changes made to the remote side are not uploaded. I believe this was previously working.

I have sent you an email with a debug version of WinSCP to the address you have used to register on this forum.

Thanks to Martin's efforts, I identified an option in Winmerge which controls whether Winmerge retains a modified file's timestamp, and it was enabled (General > Preserve file time in file compare). I don't remember enabling that setting, and I can't imagine a valid reason to do so, but now that it's disabled, everything is fine.

Thanks, Martin!