Edit and Close and save

Advertisement

Delish
Guest

Edit and Close and save

Hello,

long time ago, winscp isnt not saving and uploading files if i dont want it. Now it is so, that I open and edit a file, i didnt change the file (sometimes very big), winscp save and upload this file.

Change the Editor fix this problem, but i want to lock in some files with the Editor of winscp. There are two funktions. One of these is that you can take and open File with Editor and the other ist the viewer. I think that is the same one, there need only a check (or ask) "changed fife?" "Save it?" and not that it doing itselfs. Please change that. It was so, why it is changed?

Greeting
Delish

Reply with quote

Advertisement

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

Re: Edit and Close and save

I'm not sure if I understand. Do you mean that after you close the editor, WinSCP uploads the file back even if you haven't done any changes? What editor do you use?

Reply with quote

Guest

Re: Edit and Close and save

martin wrote:

I'm not sure if I understand. Do you mean that after you close the editor, WinSCP uploads the file back even if you haven't done any changes? What editor do you use?

Yes! it cames not at he first time. after ca one min.

I use the editor of winscp. There is also a different between editor and viewer, why? I think the editor is also looking if the file is on the server changed(?) and there is no asking befor save or something like that after i closed the window. it save it without asking. It is very .....

please make a configuration option for "only save with ask" that would be very helpfull.

Reply with quote

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

Re: Edit and Close and save

I haven't seen the problem before. And also, there's no viewer in WinSCP, so I'm confused by your post (any chance you mean WinSCP plugin for FAR, not the WinSCP application?)

Anyway, can you send me an email, so I can send you back a debug version of WinSCP to track the problem? Please include link back to this topic in your email. Also note in this topic that you have sent the email. Thanks.

You will find my address (if you log in) in my forum profile.

Reply with quote

Delish
Joined:
Posts:
3
Location:
EU

Oh yes, that's little bit confuse :)

at the first Editor and viewer
there inside could be one editor because you can take the operation what should be doing on double-click. -> Environment->Panels->Double-Click
i have "edit"

*better place could be by the editors ;) I'm searching evenry time^^

so then you have viewer and editor.

the problem by auto saving without confirm is not clear so i will help you.
I sending you an email

Reply with quote

Advertisement

Delish
Joined:
Posts:
3
Location:
EU

this problem seems only to be in version 4.1.9 build416. This debug-version and the normal new Version 4.2.5 dont haven view this problem.

Thank you.

I had that problem since last 3times updates. for that....

I will post if it comes back.

Greetings
Delish

this posting was to early, it is also the same problem. I will debug this and send it to you.

Reply with quote

Delish
Joined:
Posts:
3
Location:
EU

I found this problem. It is one of the configs of Confirmations. If you take Confirmation on overwriting of files, then it hasn't any effect(in this up written situation) without the confirmation Drag and Drop Operation.
This isn't right, because it don't tell me something about upload, it don't upload the file, how I described up here. It don't upload the file, what also shouldn't do before without the confirmation Drag and Drop Operation.

It shouldn't upload file without any change. It should ask before.

Do you have any questions, then post it.

Reply with quote

SomeUser
Guest

I'm having this same problem. Was also on build 419, so have just installed 4.2.5 - hopefully the problem will go now. Have also reenabled the confirmation for Drag & drop, just in case. Already have the confirmation for overwriting enabled.

Basically, the problem was: you open some file using WinSCP's internal editor - when closing, without making any changes, it would then reupload this file without asking for any confirmation. Causes obvious problems and seems very risky.

Reply with quote

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

SomeUser wrote:

I'm having this same problem. Was also on build 419, so have just installed 4.2.5 - hopefully the problem will go now. Have also reenabled the confirmation for Drag & drop, just in case. Already have the confirmation for overwriting enabled.

Basically, the problem was: you open some file using WinSCP's internal editor - when closing, without making any changes, it would then reupload this file without asking for any confirmation. Causes obvious problems and seems very risky.
Can you send me an email, so I can send you back a debug version of WinSCP to track the problem? Please include link back to this topic in your email. Also note in this topic that you have sent the email. Thanks.

You will find my address (if you log in) in my forum profile.

Reply with quote

Advertisement

SomeUser
Guest

Hi, thanks for replying.

I don't particularly want to run a debug build to connect to corporate servers, but I think I've identified what it is. It still occurs on 4.2.5 (624) - with all confirmations enabled. I think it's when you refresh at least once in the internal editor, and then close. If you do this, it then saves/reuploads that file without any confirmation.

Reply with quote

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

SomeUser wrote:

I don't particularly want to run a debug build to connect to corporate servers, but I think I've identified what it is. It still occurs on 4.2.5 (624) - with all confirmations enabled. I think it's when you refresh at least once in the internal editor, and then close. If you do this, it then saves/reuploads that file without any confirmation.
I wasn't able to reproduce this. I have:
- opened a session
- used F4 to open remote text file in an internal editor.
- used Ctrl+R to reload file contents
- closed the editor window
- file was NOT uploaded

Reply with quote

SomeUser
Guest

Could you try it using the interface instead of keyboard shortcuts? Steps that reproduce it here across multiple, independent installs:

1) Connect to some SFTP site
2) Right click on some file, choose 'edit'
3) In the edit window, hit the reload button - third from the left
4) Independently, not using WinSCP, edit this file so that the contents are changed
5) Close the file in WinSCP
6) Inspect the contents; for me at least, they've reverted due to a sometimes-invisible save-and-upload in step 5, with no confirmation.

Reply with quote

martin
Site Admin
martin avatar

SomeUser wrote:

4) Independently, not using WinSCP, edit this file so that the contents are changed
Edit remote file or local temporary copy?

Reply with quote

Advertisement

SomeUser
Guest

martin wrote:

SomeUser wrote:

4) Independently, not using WinSCP, edit this file so that the contents are changed
Edit remote file or local temporary copy?

The remote file - just so you can check that these changes are reverted, as WinSCP uploads what's in the edit window.

Reply with quote

martin
Site Admin
martin avatar

SomeUser wrote:

The remote file - just so you can check that these changes are reverted, as WinSCP uploads what's in the edit window.
Ok, so the editing the remote file is not necessary step to reproduce the bug, right? It is just a way to make the bug more apparent.

Reply with quote

SomeUser
Guest

Yes. I suppose you could use the modified time of the file to check, but sometimes the uploads are ninja-fast.

Are you unable to reproduce this?

Reply with quote

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

Unfortunatelly I'm indeed not able to reproduce this.

Can you send me an email, so I can send you back a debug version of WinSCP to track the problem? Please include link back to this topic in your email. Also note in this topic that you have sent the email. Thanks.

You will find my address (if you log in) in my forum profile.

Reply with quote

Advertisement

Michelsup
Guest

Hello, sorry do dig up such an old topic, but :
I have exactly the same recurent issue as described aboved.
- Build 1782
- You connect to a remote server trough SCP
- You open within the internal editor a remote text file
- You refresh the content using the "refresh button"
- You close the editor : WinSCP upload the file back to the server

It's a bit problematic when you monitor a log file for exemple.

I would be pleased to help to resolve this problem.

Thank you BTW for such a craking software :)

Reply with quote

martin
Site Admin
martin avatar
Joined:
Posts:
41,441
Location:
Prague, Czechia

Michelsup wrote:

Hello, sorry do dig up such an old topic, but :
I have exactly the same recurent issue as described aboved.
- Build 1782
- You connect to a remote server trough SCP
- You open within the internal editor a remote text file
- You refresh the content using the "refresh button"
- You close the editor : WinSCP upload the file back to the server

It's a bit problematic when you monitor a log file for exemple.
Thanks for your report.

This bug has been added to tracker:
https://winscp.net/tracker/790

Reply with quote

Advertisement

You can post new topics in this forum